Skip to content

Conversation

@Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Oct 13, 2025

Refs #467, blocked by #472

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.7.0 milestone Oct 13, 2025
@coveralls
Copy link

coveralls commented Oct 13, 2025

Pull Request Test Coverage Report for Build 19209180643

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-85.3%) to 0.0%

Totals Coverage Status
Change from base Build 19209151625: -85.3%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18467157949

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-85.3%) to 0.0%

Totals Coverage Status
Change from base Build 17751474096: -85.3%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18467157949

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-85.3%) to 0.0%

Totals Coverage Status
Change from base Build 17751474096: -85.3%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the Pierre-Sassoulas-pylint-4 branch 4 times, most recently from 9575993 to 2c805e3 Compare October 27, 2025 21:17
@Pierre-Sassoulas
Copy link
Member Author

Blocked by python 3.13 (#440) / python 3.14 support.

@mspiller
Copy link

mspiller commented Nov 8, 2025

Django 5.1 is still officially supported till EOY and shouldn't be removed.

@Pierre-Sassoulas
Copy link
Member Author

@mspiller is there any reason not to use 5.2 instead ?

@mspiller
Copy link

mspiller commented Nov 8, 2025

Well 5.1 is still supported and will be till end of the year. Having tooling that does not support officially maintained versioned is a PITA. For example we managed to migrate one of the projects from 5.1 to 5.2 just yesterday.

And before you ask :D Yes development libs are updated more often than runtime env like Django that needs lots of testing before going to prod.

@Pierre-Sassoulas
Copy link
Member Author

Sure (I put back 5.1), but I was just wondering as it's a minor version upgrading should be uneventful ? (as even upgrading a django major is uneventful in my experience)

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the Pierre-Sassoulas-pylint-4 branch from eb3e061 to 5ad934f Compare November 8, 2025 10:36
@Pierre-Sassoulas Pierre-Sassoulas marked this pull request as draft November 8, 2025 10:41
@Pierre-Sassoulas Pierre-Sassoulas changed the title Bump pylint-django version to 2.7.0 for pylint 4 Support for pylint 4.0+ Nov 8, 2025
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the Pierre-Sassoulas-pylint-4 branch from 5ad934f to e4e126a Compare November 9, 2025 06:56
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the Pierre-Sassoulas-pylint-4 branch from e4e126a to f8b9901 Compare November 9, 2025 13:27
@Pierre-Sassoulas
Copy link
Member Author

It seems something important was broken by modification in pylint 4 (lots of issue with a lot of things.). Do you have an idea what broke @carlio ?

@carlio
Copy link
Member

carlio commented Nov 10, 2025

It's finding errors in test files called func_noerror.... which are supposed to generate no errors ; my guess is that the plugin isn't being loaded by the test runner, so things which should have no errors because pylint-django supresses them are instead erroring.

This is just a guess from looking at this locally, I'll keep looking but that insight might help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants